Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete code #7712

Merged
merged 1 commit into from
Dec 2, 2024
Merged

Remove obsolete code #7712

merged 1 commit into from
Dec 2, 2024

Conversation

donnapep
Copy link
Collaborator

@donnapep donnapep commented Nov 26, 2024

Reported in p1732636371343669-slack-C07418EJ0 and 9083297-zen

Proposed Changes

Remove obsolete workaround code introduced in #2658.

Testing Instructions

  1. Sign in as a teacher.
  2. Edit/create a new course using the new block editor.
  3. Click Submit for Review and confirm.
  4. Ensure the course is saved.

Pre-Merge Checklist

  • PR title and description contain sufficient detail and accurately describe the changes
  • Adheres to coding standards (PHP, JavaScript, CSS, HTML)
  • All strings are translatable (without concatenation, handles plurals)
  • Follows our naming conventions (P6rkRX-4oA-p2)
  • Hooks (p6rkRX-1uS-p2) and functions are documented
  • New UIs are responsive and use a mobile-first approach
  • Code is tested on the minimum supported PHP and WordPress versions

@donnapep donnapep added this to the 4.24.5 milestone Nov 26, 2024
Copy link

Test the previous changes of this PR with WordPress Playground.

Copy link

Test the previous changes of this PR with WordPress Playground.

Copy link

Test the previous changes of this PR with WordPress Playground.

Copy link

Test the previous changes of this PR with WordPress Playground.

@donnapep donnapep self-assigned this Nov 28, 2024
Copy link

github-actions bot commented Dec 2, 2024

Test the previous changes of this PR with WordPress Playground.

@donnapep donnapep requested a review from a team December 2, 2024 16:18
Copy link
Member

@m1r0 m1r0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found no issues. Thanks for the cleanup. 🙂

@donnapep donnapep merged commit 523486d into trunk Dec 2, 2024
22 checks passed
@donnapep donnapep deleted the remove/obsolete-workaround branch December 2, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants